Repository navigation
Conversation
|
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes. |
|
Recreating this PR with only the changes that were supposed to be pushed in my dev branch. Note: It looks like, because the workflow file triggers every 11am, the Bot will attempt to add its commits to the data file of my branch, modifying my PR in the process with merge conflict-riddled data file changes. I'm not sure how to prevent these changes from polluting the PR before it gets merged. I am hoping that my pushing and PRing the changed file before the workflow test is run will prevent data file changes. But unless I make changes to our .gitignore file, I cannot prevent I'm open to suggestions and corrections. Let me know if you have any. Thanks! |
yepezjuan
left a comment
There was a problem hiding this comment.
Thank you for picking this up! I read through the file changes. The changes seemed appropriate. Looked through test run of the workflow and didn't give any errors.
|
Availability: TTh 9:30am-12:30pm ETA: Th 11/19 by 12:30pm |
KyleA99
left a comment
There was a problem hiding this comment.
Hey @emoore36 nice work!
- Issue is linked
- Branches in PR are correct
- Code changes are correct
- No errors in the linked log
- I saw the .json file changes are no longer in source control, thanks for handling that. I also saw the tags and other GHAs were functioning properly on this PR.
Approved!
Fixes #8586
What changes did you make?
Why did you make the changes (we will use this info to test)?
permissions:block to ensure that workflows only have the access they need by default.CodeQL Alerts
After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.
Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown
Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.
Instructions for resolving CodeQL alerts
If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.
In general, CodeQL alerts should be resolved prior to PR reviews and merging
Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)