Skip to content

Update schedule-daily-1100.yml - #8874

Open
emoore36 wants to merge 1 commit into
hackforla:gh-pagesfrom
emoore36:specify-permissions-schedule-daily-8586
Open

emoore36 wants to merge 1 commit into
hackforla:gh-pagesfrom
emoore36:specify-permissions-schedule-daily-8586

Conversation

@emoore36

Copy link
Copy Markdown
Member

Fixes #8586

What changes did you make?

  • Inserted read permission in schedule-daily-1100.yml workflow file

Why did you make the changes (we will use this info to test)?

  • To align with GitHub security best practices. We want to specify the minimum required permissions for each workflow via a top-level permissions: block to ensure that workflows only have the access they need by default.

CodeQL Alerts

After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.

Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown

Screenshot 2024-10-28 154514

Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.

  • I have checked this PR for CodeQL alerts and none were found.
  • I found CodeQL alert(s), and (select one):
    • I have resolved the CodeQL alert(s) as noted
    • I believe the CodeQL alert(s) is a false positive (Merge Team will evaluate)
    • I have followed the Instructions below, but I am still stuck (Merge Team will evaluate)
Instructions for resolving CodeQL alerts

If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.

In general, CodeQL alerts should be resolved prior to PR reviews and merging

Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)

@github-actions

Copy link
Copy Markdown

Want to review this pull request? Take a look at this documentation for a step by step guide!


From your project repository, check out a new branch and test the changes.

git checkout -b emoore36-specify-permissions-schedule-daily-8586 gh-pages
git pull https://github.com/emoore36/website.git specify-permissions-schedule-daily-8586

@github-actions github-actions Bot added role: back end/devOps Tasks for back-end developers Complexity: Medium Feature: Refactor GHA Refactoring GitHub actions to fit latest architectural norms size: 5pt Can be done in 19-30 hours labels Nov 15, 2026
@emoore36

Copy link
Copy Markdown
Member Author

Recreating this PR with only the changes that were supposed to be pushed in my dev branch.

Note: It looks like, because the workflow file triggers every 11am, the Bot will attempt to add its commits to the data file of my branch, modifying my PR in the process with merge conflict-riddled data file changes. I'm not sure how to prevent these changes from polluting the PR before it gets merged.

I am hoping that my pushing and PRing the changed file before the workflow test is run will prevent data file changes. But unless I make changes to our .gitignore file, I cannot prevent _data/external/github-data.json from being modified in this PR when I test the workflow.

I'm open to suggestions and corrections. Let me know if you have any. Thanks!

@yepezjuan yepezjuan left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for picking this up! I read through the file changes. The changes seemed appropriate. Looked through test run of the workflow and didn't give any errors.

@cchrizzle
cchrizzle self-requested a review November 16, 2026 20:55
@cchrizzle

Copy link
Copy Markdown
Member

Availability: TTh 9:30am-12:30pm
W: 12pm-12:30pm
F: 11:30am-12:30pm

ETA: Th 11/19 by 12:30pm

@KyleA99 KyleA99 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @emoore36 nice work!

  • Issue is linked
  • Branches in PR are correct
  • Code changes are correct
  • No errors in the linked log
  • I saw the .json file changes are no longer in source control, thanks for handling that. I also saw the tags and other GHAs were functioning properly on this PR.

Approved!

@github-project-automation github-project-automation Bot moved this from PR Needs review to PRs ✅ waiting for merge team in P: HfLA Website: Project Board Nov 17, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Complexity: Medium Feature: Refactor GHA Refactoring GitHub actions to fit latest architectural norms role: back end/devOps Tasks for back-end developers size: 5pt Can be done in 19-30 hours

Projects

Status: PRs ✅ waiting for merge team

Development

Successfully merging this pull request may close these issues.

Specify default permissions for schedule-daily-1100.yml

4 participants