Retire the shared project tag value from the coverage report - #228
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Retires the
project: sharedtag value from-ProjectTag, following the reversal of decision 2 of DR-Machine-to-machine-IAM-scoping on 2026-09-12. A resource belonging to no single project now carries noprojecttag at all. The wiki record was updated in the same pass (devops.wikicommitecbf3dc), with decision 2's original text and reasoning struck through rather than deleted.This is not just a deleted bucket, and that is the part worth reviewing. Removing
sharedon its own would have pushed every shared resource intomissing, turning correct state into a false-positive defect list. Somissingis renameduntagged, and both the code andscripts/README.mdnow say plainly that the bucket mixes two cases the script cannot separate:Telling them apart is a judgement per resource type, not something the report can do. That ambiguity is the genuine cost of retiring the value and it was accepted deliberately; decision 2 had existed to avoid it.
A literal
sharedvalue, should one ever appear, now falls through tononconformingrather than being recognised. That is intended and is commented where the known-values list is defined, so it does not get "fixed" back.Verification. Run against
035866691871on this branch: 77 conforming, 4 nonconforming, 24 untagged, 73.3%. The nonconforming four are the civic-tech-index SSM parameters tracked by hackforla/incubator#217, so the bucket that predicts an outage still reports truthfully. The 24 untagged are the case above in miniature — the 4 shared S3 buckets (Terraform state, CloudTrail logs) are correctly untagged, while the 10 ECS task roles are a real gap tracked by hackforla/incubator#199.Nothing was tagged
project=sharedlive — checked both regions plus the two IAM roles the tagging API cannot see. The DR was adopted 2026-09-01 but that decision was never implemented, so no resource changes state as a result of this and there is no untagging work.No issue: this follows directly from the standard changing.