Skip to content

[Issue]: Quality classes with percentages #26

Closed

Description

@MariyaSamrout

Branch Name

feature/26-quality-classes

Task

Description
Define the quality classes and the percentage applied to each one when calculating the value of a donation. The quality class should be linked to the donated item. For DB schemas we use https://dbdiagram.io/

Scope

  • quality_classes table with name and percentage
  • Link between food items and quality classes
  • Initial values to confirm with Nafissa
  • Migration

Acceptance Criteria

  • Each quality class has a name and a percentage
  • Percentages are stored as exact decimals, not floats
  • The initial values are confirmed with Nafissa
  • Migration is there

Checklist

  • I have checked for duplicate issues.
  • I have assigned the issue to the correct project board.
  • I have tagged the issue properly.

Code of Conduct

  • I agree to follow this project's Code of Conduct

Activity

  1. added this to the Sprint - 2 milestone on Oct 25, 2026
  2. lauriechammah commented on Oct 26, 2026

    @lauriechammah
    Collaborator

    Review comments:

    • Acceptance criteria should be checkboxes (- [ ]) so progress can be tracked.
    • For DB schemas we use https://dbdiagram.io/, please add the link to the description.
    • Question: should the quality class be linked to the donated item (donation line) rather than the food catalog? The same food can be donated in different conditions.
    • The migration is in the scope but not in the acceptance criteria.
    • Small fix: there's a leading space in the title.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Type

Projects

No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions