Repository navigation
chore: Replace mocha/expect/nyc with node:test harness - #33
Merged
Merged
Conversation
FotoVerite
commented
Oct 25, 2026
|
|
||
| it('should not show "Details:" if there are no properties to show', function (done) { | ||
| it( | ||
| "should toString quickly with original error", |
Contributor
Author
There was a problem hiding this comment.
I get conceptually how this works but it seems like just accepting it outputs before the timeout isn't actually testing what you would want it too.
Member
There was a problem hiding this comment.
You'd have to check the git history, but my guess is that there was a bug in toString at some point that made it take a long time, so these low-timeout tests were created to ensure a call to the function completes in less than 100ms (no assertion required)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #32