Skip to content

test: fix flaky interrupt test in OperationsTest - #603

Merged
a-oren merged 1 commit into
guacsec:mainfrom
a-oren:fix/flaky-interrupt-test
Sep 29, 2026
Merged

a-oren merged 1 commit into
guacsec:mainfrom
a-oren:fix/flaky-interrupt-test

Conversation

@a-oren

@a-oren a-oren commented Sep 29, 2026 •

Copy link
Copy Markdown
Contributor

Description

Describe what you did and why.

Related issue (if any): fixes #issue_number_goes_here

Checklist

  • I have followed this repository's contributing guidelines.
  • I will adhere to the project's code of conduct.

Additional information

Anything else?

Summary by Sourcery

Bug Fixes:

  • Stabilize the interrupted output collection test by ensuring the subprocess remains active when interruption is exercised.

@sourcery-ai

sourcery-ai Bot commented Sep 29, 2026 •

Copy link
Copy Markdown
Contributor
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

The flaky interrupt test now invokes a long-running foreground process, making interruption behavior deterministic and avoiding races caused by the previous background-process command exiting immediately.

File-Level Changes

Change Details Files
Make the interrupt test exercise a consistently running child process instead of a command that exits immediately while leaving a background process.
  • Replace the shell command with a long-running sleep.
  • Preserve the existing interruption and interrupt-status assertions while reducing timing sensitivity.
src/test/java/io/github/guacsec/trustifyda/tools/OperationsTest.java

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!

Sourcery assessment

Approved.


Sourcery is free for open source - if you like our reviews please consider sharing them ✨

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (main@874af04). Learn more about missing BASE report.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #603   +/-   ##
=======================================
  Coverage        ?   69.79%           
  Complexity      ?     1067           
=======================================
  Files           ?       66           
  Lines           ?     4436           
  Branches        ?      786           
=======================================
  Hits            ?     3096           
  Misses          ?      994           
  Partials        ?      346           
Flag Coverage Δ
integration-tests 69.79% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@a-oren
a-oren merged commit 3e94abc into guacsec:main Sep 29, 2026
41 of 44 checks passed
@a-oren
a-oren deleted the fix/flaky-interrupt-test branch September 29, 2026 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants