xds: fix identity certificate rotation with separate CA provider - #13060
Open
Anshika-019 wants to merge 1 commit into
Open
Anshika-019 wants to merge 1 commit into
Anshika-019 wants to merge 1 commit into
Conversation
|
|
shivaspeaks
requested review from
kannanjgithub
and removed request for
kannanjgithub
September 15, 2026 17:48
Member
|
Hi @Anshika-019, please sign the EasyCLA for us to review your PR. |
Anshika-019
force-pushed
the
Issue_13058
branch
from
September 15, 2026 18:01
e270355 to
e2b268a
Compare
Author
|
/easycla |
Author
|
@shivaspeaks I was signed easy cla, and test case also passed. Please check it. |
Anshika-019
force-pushed
the
Issue_13058
branch
from
September 16, 2026 07:29
e2b268a to
97413ed
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #13058
This change fixes identity certificate rotation when the identity
certificate and CA trust bundle are provided by separate
file_watcher instances.
The previous implementation cleared the saved trusted roots
after rebuilding the SslContext. When the CA provider did not
send another update, subsequent identity certificate rotations
could not rebuild the SslContext.
This change preserves the last known-good trust roots so that
identity certificate rotations can correctly rebuild the
SslContext.
Testing