Skip to content

Introduce the recently added character Alyosha to the roster - #627

Open
gridhead wants to merge 1 commit into
mainfrom
alyo
Open

Introduce the recently added character Alyosha to the roster#627
gridhead wants to merge 1 commit into
mainfrom
alyo

Conversation

@gridhead

@gridhead gridhead commented Aug 15, 2026

Copy link
Copy Markdown
Owner

Introduce the recently added character Alyosha to the roster

Fixes #581

Summary by Sourcery

Add the new playable character Alyosha to the data model, roster, assets, and tests.

New Features:

  • Define Alyosha as a new electro polearm character with base and ascension stats.
  • Expose Alyosha in character name enums and the character registry for use across the app.

Enhancements:

  • Include Alyosha’s related visual and name assets in the application resource bundles.

Tests:

  • Extend character data tests to cover Alyosha’s weapon, rarity, element, and stat progression.

@gridhead gridhead added this to the v7.0 milestone Aug 15, 2026
@gridhead
gridhead requested a review from sdglitched August 15, 2026 07:02
@gridhead gridhead self-assigned this Aug 15, 2026
@gridhead gridhead added enhancement New feature or request good first issue Good for newcomers labels Aug 15, 2026

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry @gridhead, your pull request is larger than the review limit of 150000 diff characters

@sourcery-ai

sourcery-ai Bot commented Aug 15, 2026

Copy link
Copy Markdown

Reviewer's Guide

This PR introduces the new character Alyosha across the data, type, tests, and asset layers, wiring her into the character registry and stats while adding corresponding art resources.

File-Level Changes

Change Details Files
Add Alyosha as a first-class character in the data/registry and type system.
  • Create gi_loadouts/data/char/alyosha.py defining Alyosha’s base/ascension stats, weapon, vision, rarity, and metadata.
  • Register Alyosha in gi_loadouts/data/char/init.py so she is available via the character mapping.
  • Extend CharName enum in gi_loadouts/type/char/init.py with Alyosha’s name so type-safe references work.
gi_loadouts/data/char/alyosha.py
gi_loadouts/data/char/__init__.py
gi_loadouts/type/char/__init__.py
Add tests covering Alyosha’s character data and stats.
  • Add a pytest.param block for Alyosha with weapon type, rarity, element, main stat, and level-based stat tuples.
  • Ensure Alyosha is included in the generic character test matrix alongside existing characters.
test/data/test_char.py
Add Alyosha face/wish/name/back assets and hook them into Qt resource collections.
  • Append a large WEBP blob for Alyosha’s wish/face imagery in gi_loadouts/face/rsrc/char/wish.py.
  • Update Qt resource collection files to reference Alyosha’s assets so the UI can load her images.
gi_loadouts/face/rsrc/char/wish.py
assets/back.qrc
assets/face.qrc
assets/name.qrc
assets/wish.qrc

Assessment against linked issues

Issue Objective Addressed Explanation
#581 Implement the Alyosha character in the codebase and register them in the GI Loadouts roster (including type enums and character map).
#581 Integrate Alyosha into associated resources and tests (assets and test data) so the character is usable and validated within GI Loadouts.

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@gridhead

Copy link
Copy Markdown
Owner Author

The readings do not match however.

image image 1786779401293

@gridhead
gridhead marked this pull request as draft August 15, 2026 07:38
Signed-off-by: Akashdeep Dhar <akashdeep.dhar@gmail.com>
@gridhead

Copy link
Copy Markdown
Owner Author

Close enough.

image image 1786779401293

The scaling numbers on Genshin Impact wiki are currently mistaken.

They had to be manually calculated for GI Loadouts usage.

@gridhead
gridhead marked this pull request as ready for review August 15, 2026 09:12

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry @gridhead, your pull request is larger than the review limit of 150000 diff characters

@Ank-22

Ank-22 commented Aug 15, 2026

Copy link
Copy Markdown
Contributor

I was just checking out to work on it, but it looks like it's been done already!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request good first issue Good for newcomers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add the recently added character Alyosha to the GI Loadouts roster

3 participants