Makefile: use phpcs.xml standard explicitly, expand test-matrix to 8.0-8.5#21
Merged
Conversation
….0-8.5 - lint/lint-fix pass --standard=./phpcs.xml so local lint matches CI. - test-matrix runs PHP 7.4 + 8.0, 8.1, 8.2, 8.3, 8.4, 8.5. Mirrors graze/parallel-process#37. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
lint/lint-fixpass--standard=./phpcs.xmlto phpcs/phpcbf so local lint explicitly uses the repo ruleset and matches CI.test-matrixexpanded from just7.4to 7.4 + 8.0, 8.1, 8.2, 8.3, 8.4, 8.5.graze/php-alpinepublishes-testtags for all of these, somake test-matrixruns the full matrix locally.(
PHP_VERalready defaults to7.4here, so no change was needed there.)Verification
make test(default PHP 7.4) → phpcs clean (19/19), PHPUnit 9.6.34 on PHP 7.4.26: 112 tests / 162 assertions, OK.make PHP_VER=8.5 test→ phpcs clean, PHPUnit 9.6.34 on PHP 8.5.6: 112 tests / 162 assertions, OK.🤖 Generated with Claude Code