feat(phpstan): add support for phpstan - #323
Open
damienwebdev wants to merge 10 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Currently, we don't support using
phpstanso we have less static analysis than we possibly could.Fixes: N/A
What is the new behavior?
We use
phpstanand @shochdoerfer 's https://github.com/bitExpert/phpstan-magento to statically analyze Magento further.However, for backwards compatability, this task is disabled by default. It will likely become enabled in the future. Users can opt-in by adding one of the following (depending on what you're trying to do):
Check Store
.github/check-store.json{ "$schema": "https://raw.githubusercontent.com/graycoreio/github-actions-magento2/main/resolve-check-config/check-store.schema.json", "jobs": { "phpstan": true } }Check Extension
.github/check-extension.json{ "$schema": "[../resolve-check-config/check-extension.schema.json](https://raw.githubusercontent.com/graycoreio/github-actions-magento2/main/resolve-check-config/check-extension.schema.json)", "jobs": { "phpstan": true } }Does this PR introduce a breaking change?
Other information