fix(check-extension): mirror path repos to prevent symlink errors with template files#218
Open
damienwebdev wants to merge 2 commits intomainfrom
Open
fix(check-extension): mirror path repos to prevent symlink errors with template files#218damienwebdev wants to merge 2 commits intomainfrom
damienwebdev wants to merge 2 commits intomainfrom
Conversation
…h template files Composer installs path repositories as symlinks by default, which causes Magento's template engine to fail when resolving .phtml files. Setting COMPOSER_MIRROR_PATH_REPOS=1 on all three composer install steps (unit-test, compile, integration) forces a copy instead, matching how the package would be installed from Packagist in production. Fixes #217
… errors Adds a .phtml template and an integration test to the demo package that renders it via Magento's template engine. Without COMPOSER_MIRROR_PATH_REPOS=1 the path repo is installed as a symlink and the test fails; with mirroring it passes. Closes #217
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Composer installs path repositories as symlinks by default
Fixes: #217
What is the new behavior?
Composer installs path repositories as copied files
Does this PR introduce a breaking change?
Other information