node: warn, and name both node ids, when no block ingestion runs - #6718
Open
cargopete wants to merge 1 commit into
Open
node: warn, and name both node ids, when no block ingestion runs#6718cargopete wants to merge 1 commit into
cargopete wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
[chains] ingestornames a node that is not running, nothing ingests blocks. The chain head stops advancing and every deployment sits at its current block reporting healthy, so nothing reports a problem anywhere. graph-node already logs this at INFO, but the line names only the configured ingestor and not the node's own id, so it reads as a correct statement of intent rather than a mismatch.This caught an indexer upgrading 0.41.1 to 0.45.0, crossing #6447 where the field became load-bearing. Their config said
index-node-0; the node ran asindex_node_0. Both are valid node ids so validation passes, and the log line said "Not running block ingestion, ingestor is index-node-0", which reads as correct. It took two and three quarter hours to find.This raises the line to WARN and names both ids, so the mismatch is visible in the line that already exists. Behaviour is unchanged, and
config::tests::is_block_ingestoralready covers the logic.A node deliberately not the ingestor will now warn once at startup. If you would rather that stayed INFO, I will drop the level change and keep the message.