Render SES emails using markdown#2182
Draft
DavidBiddle wants to merge 9 commits into
Draft
Conversation
The Welsh translation already has a curly apostrophe, so this makes it consistent
14f5ecd to
d4504bb
Compare
Contributor
|
🎉 A review copy of this PR has been deployed! You can reach it at: https://pr-2182.submit.review.forms.service.gov.uk/ It may take 5 minutes or so for the application to be fully deployed and working. If it still isn't ready For the sign in details and more information, see the review apps wiki page. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this pull request solve?
Trello card: https://trello.com/c/d5t1W2Hs/3151-render-ses-emails-using-markdown
Converts our existing SES email templates into markdown. This means that we no longer have to manually maintain separate HTML and plaintext templates for these emails - instead we can write a single markdown template and render it as HTML and plaintext respectively. It also reduces the number of inline styles we have to maintain.
Things to consider when reviewing