Document SQL check execution design#46
Merged
Merged
Conversation
Adds docs/design-considerations.md covering: - The two-query model (scalar + failed-rows) - Automatic COUNT(*) <-> SELECT * derivation - sqlglot-powered structural rewriting - How query shape affects annotated output mergeability - Cross-table check annotation via subquery projection Closes GTODP-155 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
- Rename "Row-level or table-level?" to "From verdict to failing rows" for a general audience - Scope the performance admonition to what vowl adds (syntactic wrapping, anti-join pattern) rather than broad SELECT * claims - Fix stale reference to "merge condition 2" (now condition 3) - Tighten intro and simplify language throughout Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
- Merge "From verdict to failing rows" into "The two-query model" as a single narrative - Make the page intro generic (not scoped to annotated output) - Move annotated-output reference link into the cross-table section where it is contextually relevant Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
nicolejh19
approved these changes
Jul 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
docs/design-considerations.mdexplaining vowl's two-query model, automatic query derivation, sqlglot-powered rewriting, and how query shape affects annotated output mergeabilitymkdocs.ymlnav🤖 Generated with Claude Code