Skip to content

chore(lint): add type-aware oxlint and enforce in pre-commit and CI - #172

Merged
wgordon17 merged 7 commits into
gordon-code:mainfrom
wgordon17:feat/site-modernization-pr1
Oct 29, 2026
Merged

wgordon17 merged 7 commits into
gordon-code:mainfrom
wgordon17:feat/site-modernization-pr1

Conversation

@wgordon17

@wgordon17 wgordon17 commented Oct 28, 2026 •

Copy link
Copy Markdown
Member

Summary

  • Adds type-aware oxlint (oxlint + oxlint-tsgolint), tsconfig.lint.json covering all app, Worker, MCP, E2E, test, and config .ts files, and TS 7 strictness flags (verbatimModuleSyntax, noFallthroughCasesInSwitch, noImplicitOverride, isolatedModules)
  • Resolves all type-aware oxlint and consistent-type-imports findings across src/, mcp/src/, tests/, e2e/, and mcp/tests/ and configures .oxlintrc.json with oxc, strict options, and file-scoped overrides
  • Enforces pnpm lint in prek pre-commit hooks and extracts shared .github/actions/{setup,verify} composite actions across CI, deploy, status-smoke, and MCP publish workflows

- Enables noFallthroughCasesInSwitch, noImplicitOverride, isolatedModules, verbatimModuleSyntax, and forceConsistentCasingInFileNames across tsconfig.json, src/shared/tsconfig.json, and mcp/tsconfig.json
- Expands tsconfig.lint.json and package.json lint scripts to cover all root and MCP config .ts files and fixes TS2305 in vitest.smoke.config.ts
- Restores the oxc plugin and adds root options (typeAware, denyWarnings, reportUnusedDisableDirectives: error) in .oxlintrc.json
- Enables eslint/no-unassigned-vars, promise/always-return, vitest/require-to-throw-message, and typescript/no-misused-spread globally and narrows remaining overrides to specific files
- Enables typescript/consistent-type-imports in .oxlintrc.json so type-only value and namespace imports (such as SolidJS JSX) are never emitted at runtime under verbatimModuleSyntax
- Marks type-only imports in ItemRow.tsx, Section.tsx, SettingRow.tsx, config.ts, events.ts, mcp/src/{resources,tools}.ts, jira-keys.test.ts, and helpers.ts
@wgordon17
wgordon17 marked this pull request as ready for review October 29, 2026 00:49
@wgordon17
wgordon17 requested a review from a team October 29, 2026 00:49
@wgordon17
wgordon17 merged commit 505e857 into gordon-code:main Oct 29, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant