test : added vitest unit tests for safeExecML script execution guard#1960
Open
tmdeveloper007 wants to merge 1 commit into
Open
test : added vitest unit tests for safeExecML script execution guard#1960tmdeveloper007 wants to merge 1 commit into
tmdeveloper007 wants to merge 1 commit into
Conversation
- Tests executable validation (python3/python allowed, bash/node rejected) - Tests argument count validation (requires at least 2 args) - Tests script name whitelisting (analyze.py allowed, others rejected) - Tests command whitelisting (predict_file/train allowed, others rejected) - Tests flag injection detection (hyphen-prefixed args rejected)
|
@tmdeveloper007 is attempting to deploy a commit to the gopaljilab's projects Team on Vercel. A member of the Team first needs to authorize it. |
github-actions
Bot
added
the
type:testing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1955.
Summary of What Has Been Done:
Added 18 vitest unit tests for the security validation paths in server/utils/exec.ts. The tests cover all security checks: executable type whitelisting (python3/python allowed, others rejected), argument count requirements, script name whitelisting (analyze.py only), command whitelisting (predict_file/train only), and flag injection detection.
Changes Made:
Impact it Made:
All 18 tests pass. Lint and typecheck clean. Improves test coverage for server/utils/.
Note: Please assign this PR to the
tmdeveloper007account.