test : added positive detection tests for detectSqlInjectionPattern#1447
Merged
Conversation
|
@tmdeveloper007 is attempting to deploy a commit to the gopaljilab's projects Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
Author
|
Workflow run awaiting maintainer approval — please approve from the Actions tab. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Owner
|
Hi @RishiByte, The build is currently failing with a few syntax and dependency errors. Here is a breakdown of what needs to be fixed to get the Vercel check passing: 1. Missing Dependency (
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1442.
Summary of What Has Been Done:
Added 17 positive-detection tests for
detectSqlInjectionPatternintests/searchValidation.test.ts. The new tests lock down the contract that every documented attack signature MUST return a non-null pattern string, and that legitimate medical-name inputs are NOT false-positively rejected. Also added atestsvitest project so this file (and other orphaned tests intests/) actually run.Changes Made:
tests/searchValidation.test.ts(+150 lines, 17 new test cases).match(input)helper inside the newdescribeblock that returns the matched pattern string (or "") so the assertions stay tight without relying on TypeScript non-null assertions (which the project's ESLint config does not parse).vitest.workspace.ts(+8 lines) — added a fourth vitest projectteststhat runstests/**/*.test.tswithenvironment: node. Excludestests/security/**andtests/e2e/**(those have their own setups).Impact it Made:
tests/searchValidation.test.ts(and 11 sibling test files) to actually run in CI.npm test(1 pre-existing failure inclient/src/components/AssessmentResult.test.tsxis unrelated to this PR and exists on main).