feat: add constructor parameter for custom Executor in cluster renderers#1682
Merged
feat: add constructor parameter for custom Executor in cluster renderers#1682
Conversation
Adds overloaded constructors to `ClusterRendererMultipleItems`, `DefaultClusterRenderer`, and `DefaultAdvancedMarkersClusterRenderer` that accept an `Executor` parameter. This allows injecting a synchronous executor (or any custom executor) during testing, resolving issues with `Executors.newSingleThreadExecutor()` creating background threads in test environments.
Contributor
Code Coverage
|
dkhawk
approved these changes
Apr 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds overloaded constructors to
ClusterRendererMultipleItems,DefaultClusterRenderer, andDefaultAdvancedMarkersClusterRendererthat accept anExecutorparameter. This allows injecting a synchronous executor (or any custom executor) during testing, resolving issues withExecutors.newSingleThreadExecutor()creating background threads in test environments.