chore : Centre camera on new location while recomposition #939
Open
LoyalAbbas wants to merge 3 commits into
Open
chore : Centre camera on new location while recomposition #939LoyalAbbas wants to merge 3 commits into
LoyalAbbas wants to merge 3 commits into
Conversation
Contributor
Code Coverage
|
kikoso
approved these changes
Jul 6, 2026
kikoso
left a comment
Collaborator
There was a problem hiding this comment.
LGTM! Aligns well with other samples.
Collaborator
|
@LoyalAbbas , since this is only a change on the demo application, not on the library itself: could you update the header to |
Author
|
@kikoso done, please check now |
Collaborator
|
@LoyalAbbas , ready to get it merged! |
dkhawk
approved these changes
Jul 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's changed
When clicking the "Change Location" button in the recomposition demo, the map camera now animates to center on the new marker location.
Why
Previously, clicking the button only moved the marker to the new coordinates while the camera stayed still. If you had panned away from Singapore, changing the location would move the marker out of view. This change ensures the camera follows the marker whenever the location changes.