feat: surface Live API session close and error events to receive() callers - #1154
Open
subhashpolisetti wants to merge 1 commit into
Open
feat: surface Live API session close and error events to receive() callers#1154subhashpolisetti wants to merge 1 commit into
subhashpolisetti wants to merge 1 commit into
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
…llers After setup, GenAiWebSocketClient only logs onClosed/onFailure — they never reach the receive() message consumer or any future, so a caller cannot react when the server closes a live session or the WebSocket drops. receive() itself returns an already-completed future (registration only), so it can't carry this either. Add an overload receive(onMessage, onError, onClose) that also surfaces error and close. The existing receive(Consumer) delegates to it, so its behavior is unchanged. onError/onClose are terminal and mutually exclusive (failure -> onError, normal close -> onClose) and may be null. Fixes googleapis#1153
subhashpolisetti
force-pushed
the
gh-live-lifecycle-callbacks
branch
from
August 3, 2026 07:58
97a355a to
3967e46
Compare
Author
|
@googlebot I signed it! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
After a Live session is established,
GenAiWebSocketClientonly logsonClosed/onFailure— they never reach thereceive()consumer or any future, so a caller can't tell when the server closes the session or the connection drops.This adds a backward-compatible overload that surfaces those events:
onError/onCloseare invoked fromonFailure/onClosedafter setup (terminal, mutually exclusive, nullable). The existingreceive(Consumer)delegates to the overload, so its behavior is unchanged.Why
Found building the Gemini Live API integration for langchain4j — the wrapper had no way to notify the app when a session ends. See #1153.
Tests
AsyncLiveTestcovers the close and error paths.Fixes #1153