Skip to content

chore(bigtable): update post-processing rules for setup.py - #18098

Merged
hebaalazzeh merged 3 commits into
mainfrom
update-bigtable-post-processing
Aug 13, 2026
Merged

chore(bigtable): update post-processing rules for setup.py#18098
hebaalazzeh merged 3 commits into
mainfrom
update-bigtable-post-processing

Conversation

@ohmayr

@ohmayr ohmayr commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

Updates the client post-processing configuration for google-cloud-bigtable in .librarian/generator-input/client-post-processing/bigtable-integration.yaml to ensure code generation produces zero diff.

Required as a result of the change in #16760

@ohmayr
ohmayr requested review from a team as code owners August 13, 2026 02:38

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the post-processing configuration and dependencies for the google-cloud-bigtable package, including adding pytest-order to system test dependencies and adjusting the setup configuration. The reviewer correctly identified that opentelemetry-api and opentelemetry-sdk were added to the post-processing configuration but are missing from the actual setup.py file, and provided a suggestion to add them to ensure the dependencies remain in sync.

Comment thread packages/google-cloud-bigtable/setup.py
@hebaalazzeh hebaalazzeh self-assigned this Aug 13, 2026

@hebaalazzeh hebaalazzeh left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hebaalazzeh
hebaalazzeh enabled auto-merge (squash) August 13, 2026 02:45
@hebaalazzeh
hebaalazzeh merged commit 9634907 into main Aug 13, 2026
49 checks passed
@hebaalazzeh
hebaalazzeh deleted the update-bigtable-post-processing branch August 13, 2026 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants