Skip to content

feat: update googleapis and regenerate - #18087

Open
JoeWang1127 wants to merge 2 commits into
googleapis:mainfrom
JoeWang1127:chore-update-libraries-2026-08-12
Open

feat: update googleapis and regenerate#18087
JoeWang1127 wants to merge 2 commits into
googleapis:mainfrom
JoeWang1127:chore-update-libraries-2026-08-12

Conversation

@JoeWang1127

@JoeWang1127 JoeWang1127 commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@JoeWang1127
JoeWang1127 requested review from a team as code owners August 12, 2026 15:12
@JoeWang1127
JoeWang1127 requested review from GarrettWu and removed request for a team August 12, 2026 15:12
@snippet-bot

snippet-bot Bot commented Aug 12, 2026 •
edited
Loading

Copy link
Copy Markdown

Here is the summary of changes.

You are about to add 80 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

gemini-code-assist[bot]
gemini-code-assist Bot reviewed Aug 12, 2026
View reviewed changes

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces several new services to the google-ads-admanager package, including ChildPublisherService, CreativeWrapperService, DaiAuthenticationKeyService, DaiEncodingProfileService, PartnerService, and ViewabilityProviderService. It also expands CompanyService with new methods for creating, batch creating, updating, and batch updating companies, along with their corresponding REST transports, pagers, client configurations, and documentation. Since there are no review comments, we have no feedback to provide.

@JoeWang1127
JoeWang1127 enabled auto-merge (squash) August 12, 2026 15:39
@JoeWang1127

JoeWang1127 commented Aug 12, 2026

Copy link
Copy Markdown
Contributor Author

System tests failed:

=================================== FAILURES ===================================
______________________ TestComputeSmoke.test_zero_values _______________________

self = 

    def test_zero_values(self):
        with self.assertRaises(expected_exception=TypeError) as ex:
            self.client.get(instance=self.name, zone=0)
>       self.assertIn(
            (
                "0 has type int, but expected one of: bytes, unicode"
                if PROTOBUF_VERSION[0] == "3"
                else "('bad argument type for built-in operation',)"
            ),
            str(ex.exception.args),
        )
E       AssertionError: "('bad argument type for built-in operation',)" not found in '("Failed to set field \'zone\' on GetInstanceRequest to value 0. Underlying error: bad argument type for built-in operation",)'

tests/system/test_smoke.py:81: AssertionError
=========================== short test summary info ============================
FAILED tests/system/test_smoke.py::TestComputeSmoke::test_zero_values - Asser...
1 failed, 17 passed in 500.82s (0:08:20)
nox > Command py.test --quiet --junitxml=system_3.12_sponge_log.xml tests/system failed with exit code 1
nox > Session system-3.12 failed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@parthea parthea parthea approved these changes
@GarrettWu GarrettWu Awaiting requested review from GarrettWu GarrettWu is a code owner automatically assigned from googleapis/bigquery-dataframe-team
+1 more reviewer
@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@JoeWang1127 @parthea