feat(bigframes): add more params to ai.classify#16990
Open
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds support for examples, endpoint, optimization_mode, and max_error_ratio parameters to the classify AI operation. The implementation includes updates to the BigQuery operations layer, Ibis and SQLglot compilers, and core operation definitions. Feedback highlights the need for a null check on the examples parameter to avoid a TypeError, suggests adding validation for max_error_ratio and its compatibility with optimization_mode, and identifies an incorrect type hint in the Ibis compiler registry.
sycai
force-pushed
the
sycai_ai_classify_update
branch
from
50da083 to
34fde7c
Compare
sycai
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
TrevorBergeron
approved these changes
May 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.