-
Notifications
You must be signed in to change notification settings - Fork 1.7k
fix(api-core): drop support for Python 3.9 #16980
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
c1c1ab1
d7b5ddc
0c736a6
821322b
87e885e
283a60e
c62b645
12c90ca
ea68a46
a7b1663
0652eb3
2d87e66
2ccd85e
10181b2
fcb7965
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -20,7 +20,7 @@ build-backend = "setuptools.build_meta" | |
| name = "google-api-core" | ||
| authors = [{ name = "Google LLC", email = "googleapis-packages@google.com" }] | ||
| license = { text = "Apache 2.0" } | ||
| requires-python = ">=3.9" | ||
| requires-python = ">=3.10" | ||
| readme = "README.rst" | ||
| description = "Google API client core library" | ||
| classifiers = [ | ||
|
|
@@ -34,7 +34,6 @@ classifiers = [ | |
| "Programming Language :: Python", | ||
| "Programming Language :: Python :: 3", | ||
|
|
||
| "Programming Language :: Python :: 3.9", | ||
| "Programming Language :: Python :: 3.10", | ||
| "Programming Language :: Python :: 3.11", | ||
| "Programming Language :: Python :: 3.12", | ||
|
|
@@ -49,7 +48,7 @@ dependencies = [ | |
| "proto-plus >= 1.22.3, < 2.0.0", | ||
| "proto-plus >= 1.25.0, < 2.0.0; python_version >= '3.13'", | ||
| "google-auth >= 2.14.1, < 3.0.0", | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Does the minimum version here need to be updated as well (since we updated constraints)? |
||
| "requests >= 2.20.0, < 3.0.0", | ||
| "requests >= 2.33.0", | ||
| ] | ||
| dynamic = ["version"] | ||
|
|
||
|
|
@@ -61,7 +60,7 @@ Repository = "https://github.com/googleapis/google-cloud-python" | |
| [project.optional-dependencies] | ||
| async_rest = ["google-auth[aiohttp] >= 2.35.0, < 3.0.0"] | ||
| grpc = [ | ||
| "grpcio >= 1.33.2, < 2.0.0", | ||
| "grpcio >= 1.80.0", | ||
| "grpcio >= 1.49.1, < 2.0.0; python_version >= '3.11'", | ||
| "grpcio >= 1.75.1, < 2.0.0; python_version >= '3.14'", | ||
| "grpcio-status >= 1.33.2, < 2.0.0", | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| # This constraints file is used to check that lower bounds | ||
| # are correct in pyproject.toml | ||
| # List *all* library dependencies and extras in this file. | ||
| # Pin the version to the lower bound. | ||
| # | ||
| # e.g., if pyproject.toml has "foo >= 1.14.0, < 2.0.0dev", | ||
| # Then this file should have foo==1.14.0 | ||
| googleapis-common-protos==1.63.2 | ||
| protobuf==4.25.8 | ||
| google-auth==2.35.0 | ||
| requests==2.33.0 | ||
| grpcio==1.80.0 | ||
| grpcio-status==1.33.2 | ||
| proto-plus==1.22.3 |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -7,8 +7,8 @@ | |
| # Then this file should have foo==1.14.0 | ||
| googleapis-common-protos==1.63.2 | ||
| protobuf==4.25.8 | ||
| google-auth==2.14.1 | ||
| requests==2.20.0 | ||
| grpcio==1.33.2 | ||
| google-auth==2.35.0 | ||
| requests==2.33.0 | ||
| grpcio==1.80.0 | ||
| grpcio-status==1.33.2 | ||
| proto-plus==1.22.3 | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. How about from We still need |
||
This file was deleted.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -34,7 +34,7 @@ | |
| from google.api_core import exceptions | ||
|
|
||
| # TODO: remove this when droppping support for "Python 3.10" and below. | ||
| if sys.version_info < (3, 10): # type: ignore[operator] | ||
| if sys.version_info <= (3, 10): # type: ignore[operator] | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Before we had It's not clear whether the original comment was wrong or the code was wrong. Can you add a comment with more context? What feature are we relying on that is only in 3.10? |
||
|
|
||
| def aiter(obj): | ||
| return obj.__aiter__() | ||
|
|
@@ -185,10 +185,6 @@ def test_done_callbacks(self): | |
| callback.assert_called_once_with(mock.sentinel.future) | ||
|
|
||
| @pytest.mark.asyncio | ||
| @pytest.mark.skipif( | ||
| sys.version_info < (3, 8), # type: ignore[operator] | ||
| reason="Versions of Python below 3.8 don't provide support for assert_awaited_once", | ||
| ) | ||
| async def test_metadata(self): | ||
| rpc, call = make_async_rpc() | ||
| bidi_rpc = bidi_async.AsyncBidiRpc(rpc, metadata=mock.sentinel.A) | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.