chore(codeowners): protect /packages/ and /core/ while allowing partner ownership of handwritten and CI checks - #9406
Merged
quirogas merged 2 commits intoSep 22, 2026
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the .github/CODEOWNERS file to redefine and expand ownership rules. Specifically, it designates the Node.js SDK team (@googleapis/cloud-sdk-nodejs-team) as co-owners for various handwritten libraries, partner-exclusive CI workflows, conformance checks, and shared workspace files such as lockfiles and release manifests. It also defines strict ownership for the /packages/ and /core/ directories. There are no review comments, and I have no additional feedback to provide.
…er ownership of handwritten and CI checks
quirogas
force-pushed
the
chore/codeowners-and-partner-ci-routing
branch
from
September 22, 2026 00:10
2082061 to
f98ae2c
Compare
quirogas
marked this pull request as ready for review
September 22, 2026 00:48
shivanee-p
approved these changes
Sep 22, 2026
quirogas
enabled auto-merge (squash)
September 22, 2026 04:28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update CODEOWNERS and assign review workflows for
/packages/and/core/to make sure any changes to this directories require core Node team approval. This changes preserves self-service workflows for partner teams across theirhandwritten/directories, releases, and CI checks.Breakdown
/packages/and/core/Ownership: Explicitly scopes/packages/and/core/to@googleapis/cloud-sdk-nodejs-team(with/core/packages/google-auth-library-nodejsco-owned with@googleapis/aion-team).handwritten/Ownership: Restores/handwritten/bigtable(@googleapis/bigtable-team) and/handwritten/pubsub(@googleapis/pubsub-team) and includes@googleapis/cloud-sdk-nodejs-teamalongside each partner team.@googleapis/cloud-sdk-nodejs-team) and PR routing inassign-reviewers.ymlfor all partner-exclusive CI workflows:.github/workflows/bigtable-conformance.yaml(@googleapis/bigtable-team).github/workflows/mandatory-conformance.yaml(@googleapis/bigtable-team).github/workflows/storage-conformance.yaml(@googleapis/gcs-team).github/workflows/system-tests-against-emulator.yaml(@googleapis/spanner-team).github/workflows/discovery.yaml(@googleapis/bigquery-team)/pnpm-lock.yaml,/.release-please-manifest.json, and/changelog.jsonso partner teams can self-service approve their ownhandwritten/dependency updates andrelease-pleasereleases.assign-reviewers.yml: Ensures that if a PR touches both partner-owned files and non-partner files (such as/packages/or/core/),assign-reviewers.ymlstill assigns a load-balancedcloud-sdk-nodejs-teamreviewer rather than strippingcloud-sdk-nodejs-team.