Conversation
Contributor
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
quirogas
force-pushed
the
ci/presubmit-librarian-generate-fastest
branch
from
September 22, 2026 00:11
9ccf2e3 to
77671aa
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updates
.github/workflows/generation_check.yamlto catch unauthorized or accidental edits underpackages/**during presubmit (pull_request) without relying on any static timing file or runninglibrarian generate --allacross all 245 libraries on every PR:packages/**todorny/paths-filterand setsfetch-depth: 2onactions/checkoutso modified files inpackages/andlibrarian.yamlare detected onpull_request.MinPriorityQueueordered by on-disk package size (totalBytesexcludingnode_modules/build) and API version count inlibrarian.yaml(score = totalBytes + apiCount * 500000).librarian generate <pkg>on the fastest 3 modified packages during presubmit (excluding libraries markedskip_generate: true), and fails immediately if any unconfigured directory/file underpackages/is modified or if regeneration produces a dirty git working tree.librarian generate --allverification onpushtomainandworkflow_dispatch.