Skip to content

feat: upgrade to latest version of gapic-generator-typescript - #9374

Draft
quirogas wants to merge 1 commit into
googleapis:mainfrom
quirogas:feat-upgrade-generator
Draft

quirogas wants to merge 1 commit into
googleapis:mainfrom
quirogas:feat-upgrade-generator

Conversation

@quirogas

@quirogas quirogas commented Sep 18, 2026

Copy link
Copy Markdown
Contributor

Summary

Upgrades gapic-generator-typescript in librarian.yaml from gapic-generator-v5.2.0 to the latest release (gapic-generator-v5.3.0), which includes the updated .nycrc configuration for generated libraries, and updates the generator build step to pass --ignore-workspace to pnpm install.

Why --ignore-workspace is Added

When librarian install builds gapic-generator-typescript from source, it downloads and extracts the googleapis/google-cloud-node archive at the specified release tag and runs pnpm install inside core/generator/gapic-generator-typescript:

  1. Monorepo Root Uses a Newer pnpm-lock.yaml Version: Between gapic-generator-v5.2.0 and gapic-generator-v5.3.0, a root pnpm-workspace.yaml and root pnpm-lock.yaml (lockfileVersion: '9.0') were added to the google-cloud-node monorepo, whereas core/generator/gapic-generator-typescript remains a standalone package with its own pnpm-lock.yaml (lockfileVersion: '6.0').
  2. Preventing Workspace Walk-Up & Lockfile Incompatibility: Without --ignore-workspace, pnpm traverses up the directory tree, detects the root pnpm-workspace.yaml, and attempts to use the monorepo root's newer lockfileVersion: '9.0' lockfile (resulting in ERR_PNPM_LOCKFILE_BREAKING_CHANGE on pnpm versions expecting lockfile v6, and targeting workspace packages rather than the standalone generator).
  3. Scoped & Deterministic Generator Install: Passing --ignore-workspace ensures pnpm install ignores the parent monorepo pnpm-workspace.yaml and installs core/generator/gapic-generator-typescript as an isolated package using its own pnpm-lock.yaml (lockfileVersion: '6.0'), keeping all resolved generator dependencies identical to v5.2.0.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the gapic-generator-typescript tool version to v5.3.0 in librarian.yaml and adds the --ignore-workspace flag to its pnpm install build step. Additionally, it removes the text reporter from the .nycrc configuration files across numerous packages, leaving only the lcov reporter. There are no review comments, so I have no feedback to provide.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant