Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the gapic-generator-typescript tool version to v5.3.0 in librarian.yaml and adds the --ignore-workspace flag to its pnpm install build step. Additionally, it removes the text reporter from the .nycrc configuration files across numerous packages, leaving only the lcov reporter. There are no review comments, so I have no feedback to provide.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Upgrades
gapic-generator-typescriptinlibrarian.yamlfromgapic-generator-v5.2.0to the latest release (gapic-generator-v5.3.0), which includes the updated.nycrcconfiguration for generated libraries, and updates the generator build step to pass--ignore-workspacetopnpm install.Why
--ignore-workspaceis AddedWhen
librarian installbuildsgapic-generator-typescriptfrom source, it downloads and extracts thegoogleapis/google-cloud-nodearchive at the specified release tag and runspnpm installinsidecore/generator/gapic-generator-typescript:pnpm-lock.yamlVersion: Betweengapic-generator-v5.2.0andgapic-generator-v5.3.0, a rootpnpm-workspace.yamland rootpnpm-lock.yaml(lockfileVersion: '9.0') were added to thegoogle-cloud-nodemonorepo, whereascore/generator/gapic-generator-typescriptremains a standalone package with its ownpnpm-lock.yaml(lockfileVersion: '6.0').--ignore-workspace,pnpmtraverses up the directory tree, detects the rootpnpm-workspace.yaml, and attempts to use the monorepo root's newerlockfileVersion: '9.0'lockfile (resulting inERR_PNPM_LOCKFILE_BREAKING_CHANGEonpnpmversions expecting lockfile v6, and targeting workspace packages rather than the standalone generator).--ignore-workspaceensurespnpm installignores the parent monorepopnpm-workspace.yamland installscore/generator/gapic-generator-typescriptas an isolated package using its ownpnpm-lock.yaml(lockfileVersion: '6.0'), keeping all resolved generator dependencies identical tov5.2.0.