Skip to content

perf(spanner): remove rest-parameter allocations in wrappedRequestFn #9365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
olavloite merged 2 commits into from
Sep 18, 2026
Merged

perf(spanner): remove rest-parameter allocations in wrappedRequestFn #9365

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
156dc83
perf(spanner): remove rest-parameter allocations in wrappedRequestFn
olavloite Sep 17, 2026
8285738
Merge branch 'main' into spanner-remove-rest-param-allocations
olavloite Sep 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
489 changes: 488 additions & 1 deletion handwritten/bigtable/testproxy/protos/protos.d.ts
View file
Open in desktop

Large diffs are not rendered by default.

1,541 changes: 1,484 additions & 57 deletions handwritten/bigtable/testproxy/protos/protos.js
View file
Open in desktop

Large diffs are not rendered by default.

168 changes: 159 additions & 9 deletions handwritten/bigtable/testproxy/protos/protos.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2994,6 +2994,10 @@
"common": {
"type": "CommonLanguageSettings",
"id": 1
},
"libraryPackage": {
"type": "string",
"id": 2
}
}
},
Expand Down Expand Up @@ -3103,6 +3107,10 @@
"rule": "repeated",
"type": "string",
"id": 3
},
"batching": {
"type": "BatchingConfigProto",
"id": 4
}
},
"nested": {
Expand Down Expand Up @@ -3160,6 +3168,79 @@
}
}
},
"BatchingConfigProto": {
"fields": {
"thresholds": {
"type": "BatchingSettingsProto",
"id": 1
},
"batchDescriptor": {
"type": "BatchingDescriptorProto",
"id": 2
}
}
},
"BatchingSettingsProto": {
"fields": {
"elementCountThreshold": {
"type": "int32",
"id": 1
},
"requestByteThreshold": {
"type": "int64",
"id": 2
},
"delayThreshold": {
"type": "google.protobuf.Duration",
"id": 3
},
"elementCountLimit": {
"type": "int32",
"id": 4
},
"requestByteLimit": {
"type": "int32",
"id": 5
},
"flowControlElementLimit": {
"type": "int32",
"id": 6
},
"flowControlByteLimit": {
"type": "int32",
"id": 7
},
"flowControlLimitExceededBehavior": {
"type": "FlowControlLimitExceededBehaviorProto",
"id": 8
}
}
},
"FlowControlLimitExceededBehaviorProto": {
"values": {
"UNSET_BEHAVIOR": 0,
"THROW_EXCEPTION": 1,
"BLOCK": 2,
"IGNORE": 3
}
},
"BatchingDescriptorProto": {
"fields": {
"batchedField": {
"type": "string",
"id": 1
},
"discriminatorFields": {
"rule": "repeated",
"type": "string",
"id": 2
},
"subresponseField": {
"type": "string",
"id": 3
}
}
},
"LaunchStage": {
"values": {
"LAUNCH_STAGE_UNSPECIFIED": 0,
Expand Down Expand Up @@ -3422,6 +3503,8 @@
"EDITION_PROTO3": 999,
"EDITION_2023": 1000,
"EDITION_2024": 1001,
"EDITION_2026": 1002,
"EDITION_UNSTABLE": 9999,
"EDITION_1_TEST_ONLY": 1,
"EDITION_2_TEST_ONLY": 2,
"EDITION_99997_TEST_ONLY": 99997,
Expand Down Expand Up @@ -3616,6 +3699,10 @@
}
},
"extensions": [
[
990,
998
],
[
1000,
536870911
Expand Down Expand Up @@ -3891,7 +3978,10 @@
"type": "bool",
"id": 10,
"options": {
"default": false
"default": false,
"feature_support.edition_introduced": "EDITION_PROTO2",
"feature_support.edition_removed": "EDITION_2024",
"feature_support.removal_error": "This behavior is enabled by default in editions 2024 and above. To disable it, you can set `features.(pb.java).nest_in_file_class = YES` on individual messages, enums, or services."
}
},
"javaGenerateEqualsAndHash": {
Expand Down Expand Up @@ -3951,7 +4041,9 @@
"type": "bool",
"id": 31,
"options": {
"default": true
"default": true,
"feature_support.edition_removed": "EDITION_2026",
"feature_support.removal_error": "cc_enable_arenas is enabled by default in every edition and overrides are ignored.This option is removed in editions 2026 and above."
}
},
"objcClassPrefix": {
Expand Down Expand Up @@ -3993,6 +4085,10 @@
}
},
"extensions": [
[
990,
998
],
[
1000,
536870911
Expand Down Expand Up @@ -4065,6 +4161,10 @@
}
},
"extensions": [
[
990,
998
],
[
1000,
536870911
Expand Down Expand Up @@ -4179,6 +4279,10 @@
}
},
"extensions": [
[
990,
998
],
[
1000,
536870911
Expand Down Expand Up @@ -4259,6 +4363,10 @@
"editionRemoved": {
"type": "Edition",
"id": 4
},
"removalError": {
"type": "string",
"id": 5
}
}
}
Expand All @@ -4278,6 +4386,10 @@
}
},
"extensions": [
[
990,
998
],
[
1000,
536870911
Expand Down Expand Up @@ -4316,6 +4428,10 @@
}
},
"extensions": [
[
990,
998
],
[
1000,
536870911
Expand Down Expand Up @@ -4360,6 +4476,10 @@
}
},
"extensions": [
[
990,
998
],
[
1000,
536870911
Expand Down Expand Up @@ -4387,6 +4507,10 @@
}
},
"extensions": [
[
990,
998
],
[
1000,
536870911
Expand Down Expand Up @@ -4421,6 +4545,10 @@
}
},
"extensions": [
[
990,
998
],
[
1000,
536870911
Expand Down Expand Up @@ -4562,8 +4690,8 @@
"retention": "RETENTION_SOURCE",
"targets": "TARGET_TYPE_METHOD",
"feature_support.edition_introduced": "EDITION_2024",
"edition_defaults.edition": "EDITION_2024",
"edition_defaults.value": "STYLE2024"
"edition_defaults.edition": "EDITION_2026",
"edition_defaults.value": "STYLE2026"
}
},
"defaultSymbolVisibility": {
Expand All @@ -4573,8 +4701,19 @@
"retention": "RETENTION_SOURCE",
"targets": "TARGET_TYPE_FILE",
"feature_support.edition_introduced": "EDITION_2024",
"edition_defaults.edition": "EDITION_2024",
"edition_defaults.value": "EXPORT_TOP_LEVEL"
"edition_defaults.edition": "EDITION_2026",
"edition_defaults.value": "STRICT"
}
},
"enforceProtoLimits": {
"type": "ProtoLimitsFeature.EnforceProtoLimits",
"id": 9,
"options": {
"retention": "RETENTION_SOURCE",
"targets": "TARGET_TYPE_ONEOF",
"feature_support.edition_introduced": "EDITION_2026",
"edition_defaults.edition": "EDITION_2026",
"edition_defaults.value": "PROTO_LIMITS2026"
}
}
},
Expand Down Expand Up @@ -4652,7 +4791,8 @@
"values": {
"ENFORCE_NAMING_STYLE_UNKNOWN": 0,
"STYLE2024": 1,
"STYLE_LEGACY": 2
"STYLE_LEGACY": 2,
"STYLE2026": 3
}
},
"VisibilityFeature": {
Expand All @@ -4674,6 +4814,18 @@
}
}
}
},
"ProtoLimitsFeature": {
"fields": {},
"nested": {
"EnforceProtoLimits": {
"values": {
"PROTO_LIMITS_UNKNOWN": 0,
"LEGACY_NO_EXPLICIT_LIMITS": 1,
"PROTO_LIMITS2026": 2
}
}
}
}
}
},
Expand Down Expand Up @@ -4944,7 +5096,6 @@
},
"type": {
"options": {
"cc_enable_arenas": true,
"go_package": "google.golang.org/genproto/googleapis/type/date;date",
"java_multiple_files": true,
"java_outer_classname": "DateProto",
Expand Down Expand Up @@ -4972,7 +5123,6 @@
},
"rpc": {
"options": {
"cc_enable_arenas": true,
"go_package": "google.golang.org/genproto/googleapis/rpc/status;status",
"java_multiple_files": true,
"java_outer_classname": "StatusProto",
Expand Down
Loading
Loading