Skip to content

fix: fix several docs generation issues - #9358

Open
feywind wants to merge 2 commits into
googleapis:mainfrom
feywind:reporx/doc-fixes
Open

feywind wants to merge 2 commits into
googleapis:mainfrom
feywind:reporx/doc-fixes

Conversation

@feywind

@feywind feywind commented Sep 16, 2026

Copy link
Copy Markdown
Contributor

This is part of the ongoing effort to reduce docs job failures.

b/545649275

@feywind
feywind requested review from a team as code owners September 16, 2026 21:38

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request splits a single glob pattern into two separate calls for '.js' and '.ts' files in 'jsdoc-region-tag', and updates the 'brace-expansion' override version to '5.0.7' in 'package.json'. Feedback highlights that 'brace-expansion' version '5.0.7' does not exist, which will cause installation failures, and that splitting the glob pattern is an inefficient workaround that should be reverted once the dependency issue is resolved.

Comment thread handwritten/firestore/package.json
Comment on lines +28 to +31
const sampleCandidates = [
...glob.sync(`${SAMPLES_DIRECTORY}/**/*.js`, {ignore: ['node_modules']}),
...glob.sync(`${SAMPLES_DIRECTORY}/**/*.ts`, {ignore: ['node_modules']}),
];

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Splitting the glob into two separate calls (**/*.js and **/*.ts) causes the directory tree to be traversed twice, which is inefficient. This workaround was likely introduced due to the broken brace-expansion dependency override. Reverting to the single glob pattern is preferred once the dependency issue is resolved.

  const sampleCandidates = glob.sync(`${SAMPLES_DIRECTORY}/**/*.{js,ts}`, {
    ignore: ['node_modules'],
  });

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll give this one a try.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant