Skip to content

chore: natively format generated TS client libraries with Prettier#8154

Open
shivanee-p wants to merge 2 commits intomainfrom
shivaneep-updated-generator-gts
Open

chore: natively format generated TS client libraries with Prettier#8154
shivanee-p wants to merge 2 commits intomainfrom
shivaneep-updated-generator-gts

Conversation

@shivanee-p
Copy link
Copy Markdown
Contributor

This PR is the first step to add a CI linter check within the monorepo. This introduces native Prettier GTS formatting directly into the GAPIC TypeScript generator (gapic-generator-typescript) so all generated code has the same formatting.

Key Changes:

  • Generator Logic (templater.ts): Integrated asynchronous prettier.format(...) using GTS rules (typescript parser, single quotes, trailing commas, mandatory semicolons).
  • Testing Baselines Updates (baselines/): Updated all 800+ .baseline snapshot files to incorporate the new Prettier formatting structure, preventing failing baseline tests.
  • Bazel Support (BUILD.bazel): Added "//:node_modules/prettier" to Bazel execution dependencies for transparent deployment support.

@shivanee-p shivanee-p requested a review from a team as a code owner May 1, 2026 23:43
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates several generated client library files for the gapic-generator-typescript. The changes primarily involve formatting adjustments, such as adding missing dependencies (e.g., prettier), updating import statements, and improving code readability through better spacing and line breaks in generated code. There are no review comments to address.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant