Repository navigation
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds a new agent skill documentation file (SKILL.md) under .agents/skills/bigquery-jdbc-testing to define conventions for writing and refactoring unit and integration tests in the BigQuery JDBC driver, along with corresponding symlinks for Claude and Gemini. To track these files, .agents/ was removed from .gitignore. The reviewer correctly pointed out that completely removing .agents/ from .gitignore might track unwanted agent-generated files, and suggested a more targeted approach to ignore .agents/* while explicitly unignoring .agents/skills/.
keshavdandeva
approved these changes
Nov 13, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding skills for tests writing in BQ JDBC