Repository navigation
fix(bigtable): enforce StreamController cancellation and flow control in MaybePointReadCallable - #14992
Open
igorbernstein2 wants to merge 5 commits into
Open
fix(bigtable): enforce StreamController cancellation and flow control in MaybePointReadCallable#14992igorbernstein2 wants to merge 5 commits into
igorbernstein2 wants to merge 5 commits into
Conversation
… in MaybePointReadCallable
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces manual flow control and improves cancellation propagation in MaybePointReadCallable by utilizing a SettableApiFuture to gate row delivery and eagerly starting the underlying RPC. It also adds comprehensive unit tests to verify these behaviors. The review feedback highlights two important improvements: addressing a potential race condition where cancellation occurs before the future reference is set, and ensuring the cancellation state is checked at the beginning of onSuccess to prevent delivering responses or completing the stream after cancellation.
mutianf
reviewed
Nov 13, 2026
mutianf
approved these changes
Nov 13, 2026
igorbernstein2
enabled auto-merge (squash)
November 13, 2026 15:55
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes
StreamController/ResponseObservercontract violations inMaybePointReadCallable:CancellationExceptiontoresponseObserver.onError(...)whenStreamController.cancel()is invoked prior to RPC completion (instead of suppressing terminal callbacks and deadlockingServerStream.iterator().hasNext()).cancelled.get()afterresponseObserver.onResponse(row)so an in-callbackcontroller.cancel()deliversonError(CancellationException)rather thanonComplete().disableAutoInboundFlowControl()andrequest(int)using aSettableApiFuture<Void>demand gate composed viaApiFutures.transformAsync.