Repository navigation
fix(gax): use TLS channel credentials for DirectPath over Interconnect - #14864
Open
kalragauri wants to merge 1 commit into
Open
kalragauri wants to merge 1 commit into
kalragauri wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces support for DirectPath xDS over Interconnect off Google Compute Engine (GCE) by negotiating TLS instead of ALTS and requiring credentials. It updates credential compatibility checks, refactors channel credential creation, improves misconfiguration logging, and adds comprehensive unit tests. The review feedback recommends returning credentials != null in isCredentialDirectPathCompatible() to prevent a potential NullPointerException when credentials are null, and ensuring that CompositeChannelCredentials and TlsChannelCredentials are properly imported to avoid compilation errors.
kalragauri
force-pushed
the
fix/gax-interconnect-tls
branch
2 times, most recently
from
October 30, 2026 07:50
00821b0 to
1576303
Compare
kalragauri
force-pushed
the
fix/gax-interconnect-tls
branch
from
October 30, 2026 07:58
1576303 to
41525ff
Compare
kalragauri
marked this pull request as ready for review
October 30, 2026 09:24
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
InstantiatingGrpcChannelProviderwrapped DirectPath over Interconnectchannels in
GoogleDefaultChannelCredentials, whose negotiator selectsALTS for every xDS cluster not prefixed
"google_cfe_". The regionalInterconnect clusters that RLS returns for data operations are not CFE
clusters, and ALTS is unavailable outside Google Cloud, so those
connections fail once the service routes to them.
The provider now builds
CompositeChannelCredentialsfromTlsChannelCredentialsand the call credentials when Interconnect isactive, so every subchannel negotiates TLS. The call credentials stay on
the channel credentials because those are the only credentials the RLS
control channel inherits from the parent channel. ALTS hard-bound tokens
are not requested on this path; they need an ALTS connection. Standard
DirectPath is unchanged.
DirectPath over Interconnect also requires credentials now, as standard
DirectPath does. Previously a channel built with
NoCredentialsProviderstill used DirectPath, and
GoogleDefaultChannelCredentialsloadedApplication Default Credentials on its own, or failed every RPC with
UNAUTHENTICATEDwhen none were available. Such a channel now fallsback to CloudPath.
The misconfiguration log covers Interconnect as well. It names the
missing credentials instead of asking for
ComputeEngineCredentials, itreports Interconnect being enabled without the
attemptDirectPathoption (or with
GOOGLE_CLOUD_DISABLE_DIRECT_PATHset), as it alreadydid for the xDS option, and it logs Interconnect misconfigurations at
WARNINGoff GCE, where Interconnect is meant to run. StandardDirectPath keeps logging at
FINEoff GCE.The credential selection moves into
createDirectPathChannelCredentialsso it can be tested withoutdialing. Tests cover the builder option, the environment variable
(including case and whitespace), invalid and
"false"values, nullcredentials with and without an mTLS client certificate provider, ALTS
hard-bound tokens on both paths, the credentials the channel builder
receives, and the new log messages and levels.