Skip to content

fix(bigtable): include reversed in Query equals, hashCode, and toString - #14799

Merged
igorbernstein2 merged 1 commit into
googleapis:mainfrom
igorbernstein2:b573788134-2
Oct 28, 2026
Merged

igorbernstein2 merged 1 commit into
googleapis:mainfrom
igorbernstein2:b573788134-2

Conversation

@igorbernstein2

Copy link
Copy Markdown
Contributor

Include builder.getReversed() in Query.equals, Query.hashCode, and Query.toString so forward and reversed queries do not compare equal.

@igorbernstein2
igorbernstein2 requested review from a team as code owners October 27, 2026 21:51

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the Query class to include the reversed property in its equals, hashCode, and toString methods. Additionally, it adds unit tests in QueryTest to verify that queries with different reversed values are not considered equal and produce different hash codes. There are no review comments, and I have no feedback to provide.

@igorbernstein2
igorbernstein2 merged commit fe9232b into googleapis:main Oct 28, 2026
205 checks passed
@igorbernstein2
igorbernstein2 deleted the b573788134-2 branch October 28, 2026 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants