Skip to content

fix(storage): send destination on gRPC copy when target BlobInfo is provided #14784

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Dhriti07 merged 3 commits into from
Oct 27, 2026
Merged

fix(storage): send destination on gRPC copy when target BlobInfo is provided #14784

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
31a2cc2
fix(storage): send destination on gRPC copy when target BlobInfo is p…
Oct 27, 2026
219c788
test(storage): verify copy with target BlobInfo does not inherit sour…
Oct 27, 2026
164e229
test(storage): restructure copy metadata test
Oct 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion ...-storage/google-cloud-storage/src/main/java/com/google/cloud/storage/GrpcStorageImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -692,7 +692,9 @@ public CopyWriter copy(CopyRequest copyRequest) {
// only set the destination if it is not equal to the default instance
// otherwise we will clobber default values populated in the gcs server side for the object
// metadata
if (!cleanedDst.equals(Object.getDefaultInstance())) {
// If the caller provided a BlobInfo target (overrideInfo), always send the destination so the

@ShreyasSinha ShreyasSinha Oct 27, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does the fix work generically for proto2, proto3 etc

@Dhriti07 Dhriti07 Oct 27, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it should work generically. The FIX always sends destination when a target BlobInfo is given, even if it's empty. Proto2 and proto3 both send an empty destination to the server and don't drop it

// server does not fall back to copying the source object's metadata.
if (copyRequest.overrideInfo() || !cleanedDst.equals(Object.getDefaultInstance())) {
Comment thread
Dhriti07 marked this conversation as resolved.
b.setDestination(cleanedDst);
}

Expand Down
25 changes: 25 additions & 0 deletions ...-storage/google-cloud-storage/src/test/java/com/google/cloud/storage/it/ITObjectTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1036,6 +1036,31 @@ public void testCopyBlobUpdateMetadata() {
assertTrue(storage.delete(gen1.getBlobId()));
}

@Test
public void testCopyBlob_targetBlobInfo_doesNotInheritMetadata() {
BlobId source = BlobId.of(bucket.getName(), generator.randomObjectName() + "-source");
Blob remoteSourceBlob =
storage.create(
BlobInfo.newBuilder(source).setMetadata(ImmutableMap.of("k", "v")).build(),
BLOB_BYTE_CONTENT);
assertNotNull(remoteSourceBlob);
BlobInfo target = BlobInfo.newBuilder(bucket, generator.randomObjectName() + "-target").build();
CopyRequest req =
CopyRequest.newBuilder()
.setSource(source)
.setTarget(target, BlobTargetOption.doesNotExist())
.build();

CopyWriter copyWriter = storage.copy(req);
Blob copied = copyWriter.getResult();

assertTrue(copyWriter.isDone());
assertThat(copied.getMetadata()).isAnyOf(null, ImmutableMap.of());

assertTrue(remoteSourceBlob.delete());
assertTrue(storage.delete(copied.getBlobId()));
}

@Test
public void testCopyBlobFail() {

Expand Down
Loading