chore: enable PG dialect integration tests in Spanner emulator - #14186
Open
tlhquynh wants to merge 1 commit into
Open
chore: enable PG dialect integration tests in Spanner emulator#14186tlhquynh wants to merge 1 commit into
tlhquynh wants to merge 1 commit into
Conversation
The Spanner emulator now supports the PostgreSQL dialect, so this removes the isUsingEmulator() checks that were skipping these integration tests in the emulator environment.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request removes the !isUsingEmulator() checks in ITQueryTest.java and ITReadTest.java, allowing PostgreSQL dialect tests to run unconditionally, even when using the emulator. It also cleans up an unused import of isUsingEmulator in ITReadTest.java. There are no review comments to address, so I have no feedback to provide.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Spanner emulator now supports the PostgreSQL dialect, so this removes the isUsingEmulator() checks that were skipping these integration tests in the emulator environment.