feat(gax): implement queryStatusCallable for resumable uploads - #14155
feat(gax): implement queryStatusCallable for resumable uploads#14155whowes wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Code Review
This pull request adds support for querying the status of an active resumable upload session by introducing QueryStatusRequest and QueryStatusResponse and implementing queryStatusCallable() in HttpJsonResumableUploadClient. Feedback on the changes highlights a critical issue where the client only accepts 2xx status codes for status queries, whereas Google's resumable upload protocol returns 308 Resume Incomplete for active uploads. The reviewer suggests updating the status check to accept 308 and adjusting the unit tests to use 308 instead of 200 for mock responses.
44dc342 to
8cfb56d
Compare
8cfb56d to
dac29ea
Compare
dac29ea to
3fadaa2
Compare
3fadaa2 to
b3608e1
Compare
|
|





This provides the ability for callers to query the server for the committed byte offset so far and detect if the upload has already finalized. This is needed for resumable uploads to be able to recover from occasional interruptions.