feat(gax): add ResumableUploadClient.startUpload() and supporting types - #14138
feat(gax): add ResumableUploadClient.startUpload() and supporting types#14138whowes wants to merge 1 commit into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
whowes
changed the title
whowes
changed the title
c0e396a to
3f2b223
Compare
|
/gemini review |
3f2b223 to
dd5cb3e
Compare
There was a problem hiding this comment.
Code Review
This pull request introduces low-level resumable upload components to the GAX library, including the ResumableUploadClient interface, the ResumableUploadSession metadata class, and the StartUploadRequest configuration class, along with their corresponding unit tests. The reviewer's feedback suggests a minor readability and performance improvement in StartUploadRequest.Builder to assign the result of getPath() to a local variable instead of invoking the getter multiple times.
whowes
changed the title
dd5cb3e to
4758549
Compare
4758549 to
0229e07
Compare
| public interface ResumableUploadClient { | ||
|
|
||
| /** Returns a {@link UnaryCallable} to initiate a resumable upload session. */ | ||
| UnaryCallable<StartUploadRequest, ResumableUploadSession> startUploadCallable(); |
There was a problem hiding this comment.
Are there any proto messages defined for the resumable upload requests? So that we don't have to define Java POJOs for them?
There was a problem hiding this comment.
I don't believe there are for the general protocol since it's natively HTTP and header-driven - happy to be corrected if I'm wrong since it'd be nice to not have to define all these AutoValue classes :)
0229e07 to
fad9e9c
Compare
|
|
2 participants
HTTP/JSON client implementation for startUpload is in #14139.