chore(pubsub): improve monorepo migration tooling#12962
chore(pubsub): improve monorepo migration tooling#12962
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a migration script for java-pubsub and updates several utility scripts for workflow transformation, generation configuration, and root POM management. The feedback highlights a critical issue where appending YAML directly to the generation config results in an invalid structure and loses deduplication logic. Additionally, there are recommendations to move imports to the top of the file for PEP 8 compliance and to harden the regex-based sorting logic in the POM update script to prevent potential runtime errors.
| if not any(f'<module>{module_name}</module>' in l for l in java_lines): | ||
| java_lines.append(new_module) | ||
| java_lines.sort() | ||
| import re |
There was a problem hiding this comment.
The import re statement should be moved to the top of the file to adhere to PEP 8 standards. Importing inside a function is generally discouraged unless there is a specific reason for lazy loading.
Updates migration automation scripts as part of the effort to migrate java-pubsub into the monorepo. Refines generation_config.yaml updating logic to prevent data loss, patches root POM sorting to preserve original formatting, and adapts CI transformers to maintain standard Clirr execution steps.
meltsufin
force-pushed
the
chore/pubsub-migration-tooling
branch
from
4b4bc1e to
edff92a
Compare
1 participant
Updates migration automation scripts as part of the effort to migrate java-pubsub into the monorepo. Refines generation_config.yaml updating logic to prevent data loss, patches root POM sorting to preserve original formatting, and adapts CI transformers to maintain standard Clirr execution steps.