chore(dataplex): backfill release notes and fix override parser#12952
Merged
chore(dataplex): backfill release notes and fix override parser#12952
Conversation
Update BEGIN_COMMIT_OVERRIDE parser to support standard conventional commit syntax (e.g., `feat(module):`) in addition to OwlBot bracket syntax (`feat: [module]`). Backfill missing Dataplex release notes that were previously excluded due to this parsing limitation. Includes a new integration test using Dataplex 1.86.0 to verify correct parsing of large squashed commits.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the release note generation script to support (short_name) delimiters and adds a new integration test for the java-dataplex module, including a golden file and updated changelog. The review feedback identifies a logic issue where multi-line commit overrides might be truncated due to line-by-line filtering and suggests improving test portability and error reporting by using sys.executable and idiomatic subprocess.run parameters.
- Update override parser to preserve newlines in multi-line commit messages (e.g., for breaking changes) instead of squashing them into single lines. - Update test suite to use `sys.executable` for cross-platform portability and `capture_output=True` for idiomatic subprocess calls. - Regenerate test goldens to reflect the corrected multi-line markdown output. - Update java-dataplex/CHANGELOG.md to reflect the corrected output.
Reverts the parser to use space-separated lines for commit descriptions, which produces cleaner single-line outputs for CHANGELOG.md. Test baselines and java-dataplex/CHANGELOG.md have been reverted to match this single-line format. The test suite portability improvements from the previous commit remain intact.
blakeli0
approved these changes
Apr 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update BEGIN_COMMIT_OVERRIDE parser to support standard conventional commit syntax (e.g.,
feat(module):) in addition to OwlBot bracket syntax (feat: [module]).Backfill missing Dataplex release notes that were previously excluded due to this parsing limitation.
Includes a new integration test using Dataplex 1.86.0 to verify correct parsing of large squashed commits.