Skip to content

fix(bqjdbc): metadata methods & getSqlTypeName for struct#12947

Open
logachev wants to merge 3 commits intomainfrom
kirl/metadata_methods
Open

fix(bqjdbc): metadata methods & getSqlTypeName for struct#12947
logachev wants to merge 3 commits intomainfrom
kirl/metadata_methods

Conversation

@logachev
Copy link
Copy Markdown
Contributor

@logachev logachev commented Apr 29, 2026

b/502644660
b/502643873

  • Fix various metadata bool methods
  • Return 'STRUCT' as SqlType name for Struct methods, name chosen due to
    • Matches the keyword for anonymous structured types in modern BigQuery Standard SQL.
    • Consistent with how the generic structural type is identified in the Google Cloud BigQuery Java SDK (StandardSQLTypeName.STRUCT).

@logachev logachev requested review from a team as code owners April 29, 2026 00:13
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the BigQuery JDBC driver to enable support for catalog-related metadata operations and batch updates. Additionally, it implements the getSQLTypeName method in BigQueryBaseStruct to return 'STRUCT' and updates the relevant unit tests. Feedback was provided to replace the hardcoded 'STRUCT' string with the StandardSQLTypeName.STRUCT.name() constant to improve maintainability and consistency with the BigQuery SDK.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants