Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions bazel/workspace0.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -103,9 +103,9 @@ def gl_cpp_workspace0(name = None):
http_archive,
name = "build_bazel_rules_apple",
urls = [
"https://github.com/bazelbuild/rules_apple/releases/download/4.3.3/rules_apple.4.3.3.tar.gz",
"https://github.com/bazelbuild/rules_apple/releases/download/5.1.0/rules_apple.5.1.0.tar.gz",
],
sha256 = "fad623b4d0dbe7883fffc95a3275eaabfd13bd9336fca6788cb40bee96e5f131",
sha256 = "ee54e3624f2c0fcac47ce917dcaae13810c83d846163f46172ec98840b49e8da",
Comment on lines +106 to +108

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

According to the release notes for rules_apple v5.0.0, WORKSPACE support has been completely removed. Since this repository is still using a WORKSPACE file (via bazel/workspace0.bzl), upgrading to 5.1.0 will break the build.\n\nTo avoid breaking the build, we should pin to the latest 4.x release (v4.5.3) which still supports WORKSPACE.

            "https://github.com/bazelbuild/rules_apple/releases/download/4.5.3/rules_apple.4.5.3.tar.gz",\n        ],\n        sha256 = "e4649d4649ef14adbc421738377d21ea75a1053d8e8f6838fc08e82328599a0f",

)

# Load Abseil
Expand Down
Loading