Conversation
There was a problem hiding this comment.
Code Review
This pull request upgrades the opentelemetry-cpp dependency to version 1.28.0 across Bazel configurations, Dockerfiles, and documentation. However, the review identified a major regression where a large portion of doc/packaging.md (including the introduction, macOS instructions, and footnotes) was accidentally deleted. Additionally, the changes in grpc_opentelemetry.cc and its test file introduce commented-out code as inline annotations; these should be replaced with clean, raw string literals, and sc::rpc::kRpcMethod should be updated to "rpc.method" for consistency.
dbolduc
left a comment
There was a problem hiding this comment.
I think we lost some of doc/packaging.md, but otherwise LG
| @@ -1,140 +1,3 @@ | |||
| # Packaging `google-cloud-cpp` | |||
|
|
||
| </details> | ||
|
|
||
| <!-- inject-distro-instructions-end --> |
|
Other than the dockerfiles I called out to update to v1.28.0, let's revert the others to their current values. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #16453 +/- ##
==========================================
- Coverage 92.28% 92.25% -0.04%
==========================================
Files 2246 2246
Lines 212913 212913
==========================================
- Hits 196497 196420 -77
- Misses 16416 16493 +77 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
No description provided.