Skip to content

feat(opentelemetry): support OpenTelemetry v1.28.0 - #16453

Open
colinmoy wants to merge 3 commits into
googleapis:mainfrom
colinmoy:feat-opentelemetry-1-28-0
Open

colinmoy wants to merge 3 commits into
googleapis:mainfrom
colinmoy:feat-opentelemetry-1-28-0

Conversation

@colinmoy

Copy link
Copy Markdown
Collaborator

No description provided.

@colinmoy
colinmoy requested a review from a team as a code owner September 15, 2026 18:19

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request upgrades the opentelemetry-cpp dependency to version 1.28.0 across Bazel configurations, Dockerfiles, and documentation. However, the review identified a major regression where a large portion of doc/packaging.md (including the introduction, macOS instructions, and footnotes) was accidentally deleted. Additionally, the changes in grpc_opentelemetry.cc and its test file introduce commented-out code as inline annotations; these should be replaced with clean, raw string literals, and sc::rpc::kRpcMethod should be updated to "rpc.method" for consistency.

Comment thread doc/packaging.md
Comment thread google/cloud/internal/grpc_opentelemetry.cc Outdated
Comment thread google/cloud/internal/grpc_opentelemetry_test.cc Outdated

@dbolduc dbolduc left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we lost some of doc/packaging.md, but otherwise LG

Comment thread doc/packaging.md
@@ -1,140 +1,3 @@
# Packaging `google-cloud-cpp`

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

restore this?

Comment thread doc/packaging.md

</details>

<!-- inject-distro-instructions-end -->

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and this.

@scotthart

Copy link
Copy Markdown
Member

Other than the dockerfiles I called out to update to v1.28.0, let's revert the others to their current values.

@codecov

codecov Bot commented Sep 15, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.25%. Comparing base (ea49720) to head (29c8f45).
⚠️ Report is 9 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #16453      +/-   ##
==========================================
- Coverage   92.28%   92.25%   -0.04%     
==========================================
  Files        2246     2246              
  Lines      212913   212913              
==========================================
- Hits       196497   196420      -77     
- Misses      16416    16493      +77     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants