Skip to content

feat(bigquery): add statement_type to PostQueryResults - #16443

Open
sachinpro wants to merge 3 commits into
googleapis:mainfrom
sachinpro:feat-query-statement-type
Open

feat(bigquery): add statement_type to PostQueryResults#16443
sachinpro wants to merge 3 commits into
googleapis:mainfrom
sachinpro:feat-query-statement-type

Conversation

@sachinpro

Copy link
Copy Markdown
Contributor

Adds statement_type to PostQueryResults in bigquery_v2_minimal_internal to parse the statementType field returned by BigQuery's jobs.query API.

@sachinpro
sachinpro requested a review from a team as a code owner September 11, 2026 20:49
@product-auto-label product-auto-label Bot added the api: bigquery Issues related to the BigQuery API. label Sep 11, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds support for the statement_type field in PostQueryResults. The field is parsed from and serialized to JSON, included in the debug string representation, and integrated into the corresponding unit tests and test utilities. There are no review comments to address, and I have no additional feedback to provide.

@sachinpro

Copy link
Copy Markdown
Contributor Author

Hey @dbolduc, thanks for approving this.

Can you please also /gcbrun before merging?

@dbolduc

dbolduc commented Sep 11, 2026

Copy link
Copy Markdown
Member

/gcbrun

@codecov

codecov Bot commented Sep 11, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.29%. Comparing base (5fe64b3) to head (2eee6e8).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #16443      +/-   ##
==========================================
+ Coverage   92.26%   92.29%   +0.03%     
==========================================
  Files        2246     2246              
  Lines      212913   212927      +14     
==========================================
+ Hits       196445   196522      +77     
+ Misses      16468    16405      -63     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sachinpro

Copy link
Copy Markdown
Contributor Author

@dbolduc, @scotthart , I added a commit to fix code coverage. Please /gcbrun again.

@dbolduc

dbolduc commented Sep 12, 2026

Copy link
Copy Markdown
Member

/gcbrun

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigquery Issues related to the BigQuery API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants