feat(storage): support DirectPath over Interconnect in GCS gRPC - #16408
feat(storage): support DirectPath over Interconnect in GCS gRPC#16408kalragauri wants to merge 3 commits into
Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces the DirectPathXdsOverInterconnectOption and the corresponding environment variable GOOGLE_CLOUD_ENABLE_DIRECT_PATH_XDS_OVER_INTERCONNECT to allow configuring DirectPath over Interconnect. When enabled, the client targets google-c2p:///storage-direct.googleapis.com?force-xds with standard TLS. Comprehensive unit tests have been added to cover various scenarios and overrides. Feedback is provided regarding a style guide violation where auto is used for a boolean type instead of an explicit bool const declaration.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #16408 +/- ##
========================================
Coverage 92.28% 92.29%
========================================
Files 2246 2246
Lines 212913 213095 +182
========================================
+ Hits 196491 196677 +186
+ Misses 16422 16418 -4 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
9218fd4 to
b667bda
Compare
This PR adds support for DirectPath over Interconnect in the Cloud Storage gRPC client library.
Summary of Changes
storage_experimental::DirectPathXdsOverInterconnectOptionand support for theGOOGLE_CLOUD_ENABLE_DIRECT_PATH_XDS_OVER_INTERCONNECTenvironment variable.storage_internal::DefaultOptionsGrpcto resolve target endpointgoogle-c2p:///storage-direct.googleapis.com?force-xdswith authoritystorage.googleapis.comwhen enabled, bypassing GCE environment checks.