feat(storage): Extend idempotency token use to all async mutation operations#16100
feat(storage): Extend idempotency token use to all async mutation operations#16100kalragauri wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Code Review
This pull request standardizes the addition of idempotency tokens across asynchronous storage operations—specifically Insert, Compose, Delete, and Appendable Uploads—by utilizing a new AddIdempotencyToken helper function. The changes include updating the AsyncConnectionImpl to capture and apply invocation IDs and adding unit tests to verify token presence in gRPC metadata. Review feedback recommends using GoogleMock matchers to simplify metadata verification in tests and removing an unused variable.
38e0028 to
2b7d63b
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #16100 +/- ##
==========================================
- Coverage 92.69% 92.68% -0.01%
==========================================
Files 2353 2353
Lines 218328 218377 +49
==========================================
+ Hits 202386 202413 +27
- Misses 15942 15964 +22 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This change extends the use of idempotency tokens to all mutation operations within the asynchronous gRPC-based client library. A unique token is generated client-side and included in the request metadata under the
x-goog-gcs-idempotency-tokenheader.