feat(storage): Add delete object source field in ComposeObject API#16094
Merged
Conversation
product-auto-label
Bot
added
the
api: storage
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces the DeleteSourceObjects option for ComposeObject requests, implementing support in both gRPC and REST paths. It also includes integration tests to verify the behavior when the option is enabled or disabled. Feedback was provided to simplify the option retrieval logic using value_or(false) for better readability and to add a docstring to the new public-facing DeleteSourceObjects parameter.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #16094 +/- ##
=======================================
Coverage 92.71% 92.72%
=======================================
Files 2353 2353
Lines 218692 218752 +60
=======================================
+ Hits 202764 202827 +63
+ Misses 15928 15925 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
v-pratap
force-pushed
the
delete-object-source
branch
from
b5077ac to
53036f9
Compare
kalragauri
reviewed
May 18, 2026
kalragauri
approved these changes
May 18, 2026
v-pratap
force-pushed
the
delete-object-source
branch
from
53036f9 to
5a258f9
Compare
v-pratap
force-pushed
the
delete-object-source
branch
from
a305131 to
7abd039
Compare
elinorli
pushed a commit
to elinorli/google-cloud-cpp
that referenced
this pull request
May 19, 2026
…oogleapis#16094) * feat(storage): Add delete object source in compose object api * add implementation of delete object source * resolve ai comments * resolve the review comments * fix the format
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.