Skip to content

fix: correct ClientSecrets JSON.dump constant #28074

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
quartzmo merged 2 commits into from
Oct 15, 2026
Merged

fix: correct ClientSecrets JSON.dump constant #28074

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fbf1aea
fix: serialize ClientSecrets with JSON.generate
OskarEichler Oct 2, 2026
458134e
fix: use JSON.dump for client secrets serialization
OskarEichler Oct 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion google-apis-core/lib/google/api_client/client_secrets.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@ def initialize(options={})
# @return [String]
# JSON
def to_json
return Json.dump(to_hash)
return JSON.dump(to_hash)
end

def to_hash
Expand Down
8 changes: 8 additions & 0 deletions google-apis-core/spec/google/api_client/client_secrets_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,14 @@
FIXTURES_PATH = File.expand_path('../../../fixtures', __FILE__)

RSpec.describe Google::APIClient::ClientSecrets do
describe '#to_json' do
let(:secrets) { described_class.new('installed' => { 'client_id' => 'example-client' }) }

it 'serializes the client secrets hash' do
expect(JSON.parse(secrets.to_json)).to eq(secrets.to_hash)
end
end

describe '::new' do
let(:filename) { File.join(FIXTURES_PATH, 'files', 'client_secrets.json') }
let(:data) { File.open(filename, 'r') { |file| JSON.load(file.read) } }
Expand Down
Loading