Repository navigation
google-apis-core: ClientSecrets#to_json raises NameError #27757
Description
Google::APIClient::ClientSecrets#to_json calls Json.dump, but no Json constant exists, so the documented serialization method raises NameError.
Minimal reproduction on google-apis-core 1.2.5/current:
require "google/api_client/client_secrets"
Google::APIClient::ClientSecrets.new("installed" => {"client_id" => "id"}).to_json
# NameError: uninitialized constant Google::APIClient::ClientSecrets::JsonA focused correction uses JSON.generate(to_hash, *args), which also preserves the JSON.generate(secrets) callback signature. The candidate passes the focused model, 88 targeted examples, and the cumulative 509-example core suite on Ruby 4.0.6.
I found no open issue/PR overlap. I have a minimal patch ready and can submit it after maintainer acceptance per CONTRIBUTING. The source audit and candidate preparation used AI assistance; I reviewed and verified the result.
Metadata
Metadata
Assignees
Labels
No labels
Activity
torreypayne commentedon Oct 1, 2026
@OskarEichler Thanks for the report and the clear reproduction — confirmed on main.
Please go ahead and open the PR. Your
JSON.generate(to_hash, *args)approach is fine (to_hash.to_json(*args) is equivalent). Please title itfix: ...and add a spec coveringto_jsonandJSON.generate(secrets).OskarEichler commentedon Oct 2, 2026
Opened #28074 with the requested fix: title and regression specs for both direct to_json and JSON.generate(secrets). The 88 ClientSecrets examples and full 502-example core suite pass on Ruby 4.0.6. The PR records the legacy RuboCop startup limitation separately.