Repository navigation
feat: support Python 3.15 - #2837
Conversation
product-auto-label
Bot
added
size: m
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds support for Python 3.15 across the repository, updating CI configurations (Kokoro, GitHub repository settings), documentation (README, CONTRIBUTING), and testing configurations (noxfile, owlbot, setup.py). However, the testing/constraints-3.15.txt file is missing, which will cause the newly added unit-3.15 Nox session to fail when trying to install dependencies from the non-existent constraints file.
|
|
||
| - The feature must work fully on the following CPython versions: | ||
| 3.10, 3.11, 3.12, 3.13, and 3.14 on both UNIX and Windows. | ||
| 3.10, 3.11, 3.12, 3.13, 3.14, and 3.15 on both UNIX and Windows. |
There was a problem hiding this comment.
This is ancillary to your task, but:
In the monorepo, we migrated to a central CONTRIBUTING.rst file and dropped all references to versions. If a user wants to know what the supported versions are, there are better canonical sources in our code base OR PyPI that provide this info (pyproject.toml, setup.py, etc).
We deemed repeating this set of edits to this file every time we change anything about a runtime to be more effort than it was worth.
Here is a link to the slimmer file we use in the monorepo for comparison.
There was a problem hiding this comment.
Good point, I'll make the change
chalmerlowe
left a comment
chalmerlowe
left a comment
There was a problem hiding this comment.
LGTM, but I would consider replacing the contributing.rst with a doc that is runtime version agnostic to save labor from here on out. See more detailed comment in the Thread.
daniel-sanche
changed the title
2 participants
Adds classifier declaring 3.15 support to google-api-python-client