Conversation
jradcliff
force-pushed
the
dryrun
branch
2 times, most recently
from
September 21, 2026 16:48
3086d17 to
9ab6fad
Compare
The Artifact Registry enforces NPM version immutability, so a version is consumed and can't be reused as soon as it is uploaded. This differs from other languages, where a version isn't consumed until a manifest upload triggers publishing. This change moves the dry run check to *before* the AR upload to avoid consuming semantic versions during testing. Change-Id: Iee20ed0b7fbc85a573568762a641b77be1330a9f
lindsey-volta
approved these changes
Sep 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Artifact Registry enforces NPM version immutability, so a version is consumed and can't be reused as soon as it is uploaded. This differs from other languages, where a version isn't consumed until a manifest upload triggers publishing.
This change moves the dry run check to before the AR upload to avoid consuming semantic versions during testing.
Change-Id: Iee20ed0b7fbc85a573568762a641b77be1330a9f